Fix goreleaser #2333
Merged
Fix goreleaser #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soneillf5
approved these changes
Jan 6, 2022
Codecov Report
@@ Coverage Diff @@
## master #2333 +/- ##
=======================================
Coverage 53.68% 53.68%
=======================================
Files 48 48
Lines 14199 14199
=======================================
Hits 7623 7623
Misses 6338 6338
Partials 238 238 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There's a bug in the pipeline when we push a tag - goreleaser won't work with the "--id" flag when we are releasing the binaries. See https://github.com/nginxinc/kubernetes-ingress/runs/4727732721?check_suite_focus=true for the failed run.
Checklist
Before creating a PR, run through this checklist and mark each as complete.