Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to more tests. #2355

Merged
merged 1 commit into from Jan 14, 2022
Merged

Add retries to more tests. #2355

merged 1 commit into from Jan 14, 2022

Conversation

ciarams87
Copy link
Member

Proposed changes

Some tests are failing pretty consistently in test runs, but often pass on a retry. This commit marks them as flaky.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@codecov-commenter
Copy link

Codecov Report

Merging #2355 (f6fed13) into master (0e9556a) will not change coverage.
The diff coverage is n/a.

❗ Current head f6fed13 differs from pull request most recent head cf46ca6. Consider uploading reports for the commit cf46ca6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2355   +/-   ##
=======================================
  Coverage   53.69%   53.69%           
=======================================
  Files          48       48           
  Lines       14201    14201           
=======================================
  Hits         7625     7625           
  Misses       6338     6338           
  Partials      238      238           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9556a...cf46ca6. Read the comment docs.

@ciarams87 ciarams87 merged commit 6c014f6 into master Jan 14, 2022
@ciarams87 ciarams87 deleted the flaky-tests-round-3 branch January 14, 2022 09:06
@lucacome lucacome added the tests Pull requests that update tests label Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants