Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UBI 7 and condense WAF/DOS builds #2362

Merged
merged 4 commits into from Jan 19, 2022
Merged

Remove UBI 7 and condense WAF/DOS builds #2362

merged 4 commits into from Jan 19, 2022

Conversation

lucacome
Copy link
Member

  • NAP WAF and DoS now support UBI 8, we don't need UBI 7 anymore
  • Reduced the duplication for installing NAP modules

@lucacome lucacome requested a review from a team January 19, 2022 01:27
@lucacome lucacome self-assigned this Jan 19, 2022
@lucacome lucacome requested review from pleshakov and ciarams87 and removed request for a team January 19, 2022 01:27
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation labels Jan 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022 •
edited

Codecov Report

Merging #2362 (eae20a8) into master (7a702f8) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2362      +/-   ##
==========================================
+ Coverage   53.66%   53.69%   +0.02%     
==========================================
  Files          48       48              
  Lines       14201    14201              
==========================================
+ Hits         7621     7625       +4     
+ Misses       6340     6338       -2     
+ Partials      240      238       -2
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.86% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a702f8...eae20a8. Read the comment docs.

ciarams87
ciarams87 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

pleshakov
pleshakov approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+58 −126 nice 👍

@lucacome lucacome merged commit 9305313 into master Jan 19, 2022
@lucacome lucacome deleted the chore/remove-ubi7 branch January 19, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lucacome @codecov-commenter @pleshakov @ciarams87