Use IC_VERSION only on tags in CI #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
requested review from
pleshakov and
ciarams87
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #2382 +/- ##
==========================================
- Coverage 53.69% 53.66% -0.03%
==========================================
Files 48 48
Lines 14201 14201
==========================================
- Hits 7625 7621 -4
- Misses 6338 6340 +2
- Partials 238 240 +2
Continue to review full report at Codecov.
|
ciarams87
approved these changes
Jan 25, 2022
pleshakov
approved these changes
Jan 25, 2022
lucacome
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use the version on new tags, that's when we actually only need that value to be set.