Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notification and add alpine-opentracing #2406

Merged
merged 1 commit into from Feb 16, 2022
Merged

Fix notification and add alpine-opentracing #2406

merged 1 commit into from Feb 16, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Feb 3, 2022

  • Fixes quotes in notification message (if the commit message contained " it would fail to send the notification)
  • Adds build for Alpine with opentracing
  • Adds build for s390x for UBI

@lucacome lucacome requested a review from a team February 3, 2022 08:07
@lucacome lucacome self-assigned this Feb 3, 2022
@lucacome lucacome requested review from haywoodsh, ciarams87 and pleshakov and removed request for a team February 3, 2022 08:07
@lucacome lucacome enabled auto-merge (squash) February 3, 2022 08:08
@github-actions github-actions bot added bug An issue reporting a potential bug chore Pull requests for routine tasks labels Feb 3, 2022
@lucacome lucacome removed the bug An issue reporting a potential bug label Feb 3, 2022
ciarams87
ciarams87 approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@github-actions github-actions bot added the bug An issue reporting a potential bug label Feb 16, 2022
@lucacome lucacome removed the bug An issue reporting a potential bug label Feb 16, 2022
@lucacome lucacome merged commit e3ddd0d into master Feb 16, 2022
@lucacome lucacome deleted the chore/fix-docker-update branch February 16, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucacome @pleshakov @ciarams87