Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle tests #2450

Merged
merged 5 commits into from Feb 28, 2022
Merged

Shuffle tests #2450

merged 5 commits into from Feb 28, 2022

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Feb 24, 2022

Proposed changes

Run unit tests with shuffle option.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@jjngx jjngx added the tests Pull requests that update tests label Feb 24, 2022
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jjngx jjngx requested a review from pleshakov February 24, 2022 15:44
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #2450 (32147f2) into master (666cf9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2450   +/-   ##
=======================================
  Coverage   53.66%   53.66%           
=======================================
  Files          48       48           
  Lines       14200    14200           
=======================================
  Hits         7620     7620           
  Misses       6342     6342           
  Partials      238      238           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666cf9e...32147f2. Read the comment docs.

@jjngx jjngx merged commit 3366786 into nginxinc:master Feb 28, 2022
@jjngx jjngx deleted the jjngx/shuffle-tests branch March 1, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants