Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show available make targets #2467

Merged
merged 1 commit into from Mar 1, 2022
Merged

Show available make targets #2467

merged 1 commit into from Mar 1, 2022

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Mar 1, 2022

Proposed changes

make command defaults to target help. This behaviour aligns with make command in the root folder of the project.

Example:

➜  tests git:(acceptance-tests) ✗ make
help                 Show available make targets
build                Run build
run-tests            Run tests
run-tests-in-kind    Run tests in Kind
create-kind-cluster  Create Kind cluster
delete-kind-cluster  Delete Kind cluster

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@jjngx jjngx added the tests Pull requests that update tests label Mar 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2467 (30341af) into master (9c4a516) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2467   +/-   ##
=======================================
  Coverage   53.66%   53.66%           
=======================================
  Files          48       48           
  Lines       14200    14200           
=======================================
  Hits         7620     7620           
  Misses       6342     6342           
  Partials      238      238           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4a516...30341af. Read the comment docs.

@jjngx jjngx merged commit 773bb1a into nginxinc:master Mar 1, 2022
@jjngx jjngx deleted the acceptance-tests branch March 1, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants