Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #2468

Merged
merged 2 commits into from Mar 3, 2022
Merged

Update documentation #2468

merged 2 commits into from Mar 3, 2022

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Mar 1, 2022

Proposed changes

Update documentation (README.md file in the tests dir) to reflect:

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@jjngx jjngx added documentation Pull requests/issues for documentation tests Pull requests that update tests labels Mar 1, 2022
pleshakov
pleshakov approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jjngx jjngx added documentation Pull requests/issues for documentation and removed documentation Pull requests/issues for documentation tests Pull requests that update tests labels Mar 2, 2022
@ciarams87 ciarams87 merged commit c561adf into nginxinc:master Mar 3, 2022
@jjngx jjngx deleted the test-docs branch March 3, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@eufinco eufinco Awaiting requested review from eufinco

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjngx @pleshakov @ciarams87