Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests for AWS #2483

Merged
merged 2 commits into from Mar 15, 2022
Merged

Run tests for AWS #2483

merged 2 commits into from Mar 15, 2022

Conversation

lucacome
Copy link
Member

Adds tags parameter to include AWS specific tests

@lucacome lucacome requested review from jjngx and a team March 11, 2022 22:11
@lucacome lucacome self-assigned this Mar 11, 2022
@github-actions github-actions bot added the tests Pull requests that update tests label Mar 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #2483 (0c7d7f7) into master (d83e04c) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
- Coverage   53.62%   53.45%   -0.18%     
==========================================
  Files          48       49       +1     
  Lines       14220    14296      +76     
==========================================
+ Hits         7626     7642      +16     
- Misses       6351     6411      +60     
  Partials      243      243              
Impacted Files Coverage Δ
cmd/nginx-ingress/aws.go 21.05% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome requested a review from eufinco March 15, 2022 00:46
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@lucacome lucacome merged commit 8bf19ee into master Mar 15, 2022
@lucacome lucacome deleted the tests/add-aws branch March 15, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants