Updates to pull-ingress-controller-image doc #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jcahilltorre
approved these changes
Mar 23, 2022
- Fix broken links reported by field - Update link target text so that instead of using "here", they have descriptions of the target documents. This is especially important when linking out to external locations (like the Docker docs) - Use hugo `relref` for internal doc links -- when these are used, hugo build will fail if the link is broken - Change "e.g." to "for example" -- brings us into compliance with internal style guide
jputrino
force-pushed
the
fix-typo-pull-image
branch
from
5ab0bee
to
2a0f459
Compare
lucacome
reviewed
Mar 23, 2022
lucacome
approved these changes
Mar 23, 2022
Co-authored-by: Luca Comellini <luca.com@gmail.com>
jputrino
added a commit
that referenced
this pull request
Mar 23, 2022
- Fix broken links reported by field - Update link target text so that instead of using "here", they have descriptions of the target documents. This is especially important when linking out to external locations (like the Docker docs) - Use hugo `relref` for internal doc links -- when these are used, hugo build will fail if the link is broken - Change "e.g." to "for example" -- brings us into compliance with internal style guide
lucacome
pushed a commit
that referenced
this pull request
Mar 23, 2022
…ranch (#2530) (#2531) - Fix broken links reported by field - Update link target text so that instead of using "here", they have descriptions of the target documents. This is especially important when linking out to external locations (like the Docker docs) - Use hugo `relref` for internal doc links -- when these are used, hugo build will fail if the link is broken - Change "e.g." to "for example" -- brings us into compliance with internal style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relreffor internal doc links -- when these are used, hugo build will fail if the link is brokenProposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.