Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1.2 #2561

Merged
merged 3 commits into from Mar 29, 2022
Merged

Release 2.1.2 #2561

merged 3 commits into from Mar 29, 2022

Conversation

lucacome
Copy link
Member

Updates docs and CIs for 2.1.2

@lucacome lucacome requested review from pleshakov, eufinco and a team March 29, 2022 19:07
@lucacome lucacome self-assigned this Mar 29, 2022
@lucacome lucacome requested a review from jjngx March 29, 2022 19:07
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation labels Mar 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #2561 (f975578) into release-2.1 (b2c1900) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-2.1    #2561   +/-   ##
============================================
  Coverage        53.66%   53.66%           
============================================
  Files               48       48           
  Lines            14201    14201           
============================================
  Hits              7621     7621           
  Misses            6340     6340           
  Partials           240      240           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

README.md Outdated Show resolved Hide resolved
@@ -8,7 +8,7 @@ toc: true
---

This document describes how to configure the NGINX App Protect Dos module
> Check out the complete [NGINX Ingress Controller with App Protect Dos example resources on GitHub](https://github.com/nginxinc/kubernetes-ingress/tree/v2.1.1/examples/appprotect-dos).
> Check out the complete [NGINX Ingress Controller with App Protect Dos example resources on GitHub](https://github.com/nginxinc/kubernetes-ingress/tree/v2.1.2/examples/appprotect-dos).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Check out the complete [NGINX Ingress Controller with App Protect Dos example resources on GitHub](https://github.com/nginxinc/kubernetes-ingress/tree/v2.1.2/examples/appprotect-dos).
> Check out the complete [NGINX Ingress Controller with App Protect DoS example resources on GitHub](https://github.com/nginxinc/kubernetes-ingress/tree/v2.1.2/examples/appprotect-dos).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs to be fixed throughout the doc, this can be handled as a separate bug if desired.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated in all the docs

@lucacome lucacome merged commit 1ee492a into release-2.1 Mar 29, 2022
@lucacome lucacome deleted the chore/release-2.1.2 branch March 29, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants