Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dockerfile 1.4 #2567

Merged
merged 2 commits into from Apr 6, 2022
Merged

Use Dockerfile 1.4 #2567

merged 2 commits into from Apr 6, 2022

Conversation

lucacome
Copy link
Member

Improvements:

  • Use --link to not invalidate the layer even if previous layers have changed (see docs)
  • Use cache when building in container to speed up build and mount the directory removing the need to copy the source code.

@lucacome lucacome requested a review from a team March 30, 2022 19:40
@lucacome lucacome self-assigned this Mar 30, 2022
@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #2567 (71a1359) into main (89a49b7) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2567      +/-   ##
==========================================
- Coverage   53.52%   53.50%   -0.02%     
==========================================
  Files          49       49              
  Lines       14314    14314              
==========================================
- Hits         7661     7659       -2     
  Misses       6412     6412              
- Partials      241      243       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.47% <0.00%> (-0.39%) ⬇️
...ternal/k8s/appprotect/app_protect_configuration.go 86.74% <0.00%> (+0.57%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome requested a review from eufinco April 5, 2022 22:03
@lucacome lucacome merged commit 95fd169 into main Apr 6, 2022
@lucacome lucacome deleted the chore/dockerfile-1.4 branch April 6, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants