Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report expected controller #2642

Merged
merged 2 commits into from May 4, 2022
Merged

Report expected controller #2642

merged 2 commits into from May 4, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 3, 2022

Proposed changes

The error reporting when the controller doesn't match is painful to debug -- reporting the other side of the equality makes life so much better.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome lucacome requested review from a team, haywoodsh, ciarams87 and jjngx May 4, 2022 07:56
lucacome
lucacome approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaks @jsoref, LGTM!

@lucacome lucacome merged commit 0bc7fcb into nginxinc:main May 4, 2022
@jsoref jsoref deleted the controller-expected-value branch May 4, 2022 12:13
@lucacome lucacome added the documentation Pull requests/issues for documentation label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh is a code owner automatically assigned from nginxinc/kic

@jjngx jjngx Awaiting requested review from jjngx jjngx is a code owner automatically assigned from nginxinc/kic

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsoref @lucacome @ciarams87