Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-spiffe to v2 #2652

Merged
merged 1 commit into from May 5, 2022
Merged

Update go-spiffe to v2 #2652

merged 1 commit into from May 5, 2022

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented May 4, 2022

Proposed changes

Updated the go-spiffe package to v2. Reworked the spiffe controller (now called spiffe cert fetcher) to use the new structure defined in this package to receive and write certs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman
Update go-spiffe to v2
190f35d 
Updated the go-spiffe package to v2. Reworked the spiffe controller (now called spiffe cert fetcher) to use the new structure defined in this package to receive and write certs.
@lucacome lucacome requested review from a team, ciarams87, jjngx and shaun-nx May 4, 2022 22:01
lucacome
lucacome approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lucacome lucacome merged commit cfa5d6e into nginxinc:main May 5, 2022
@lucacome lucacome added the dependencies Pull requests that update a dependency file label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@jjngx jjngx Awaiting requested review from jjngx jjngx is a code owner automatically assigned from nginxinc/kic

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx is a code owner automatically assigned from nginxinc/kic

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjberman @lucacome @ciarams87