Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new directive for dos: app_protect_dos_arb_fqdn #2745

Merged
merged 1 commit into from Aug 24, 2022

Conversation

pasmant
Copy link
Contributor

@pasmant pasmant commented Jun 9, 2022

Added - app-protect-dos-arb-fqdn - new option in Config Map

Arbitrator FQDN has one argument which is the FQDN/IP.
The argument is the FQDN to the desired Arbitrator.

Examples for ConfigMap data:

FQDN:

data:
  app-protect-dos-arb-fqdn svc-appprotect-dos-arb.arb.svc.cluster.local;

IP address:

data:
  app-protect-dos-arb-fqdn 192.168.1.10;

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #2745 (730bfbc) into main (fea43bc) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

❗ Current head 730bfbc differs from pull request most recent head 7f2514f. Consider uploading reports for the commit 7f2514f to get more accurate results

@@            Coverage Diff             @@
##             main    #2745      +/-   ##
==========================================
- Coverage   52.32%   52.31%   -0.02%     
==========================================
  Files          58       58              
  Lines       15959    15965       +6     
==========================================
+ Hits         8351     8352       +1     
- Misses       7330     7335       +5     
  Partials      278      278              
Impacted Files Coverage Δ
internal/configs/config_params.go 76.74% <ø> (ø)
internal/configs/version1/config.go 0.00% <ø> (ø)
internal/configs/configmaps.go 18.20% <16.66%> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pasmant left some comments. Would also mind adding a description for the changes in this PR? Thanks!

tests/suite/test_dos.py Show resolved Hide resolved
tests/suite/test_dos.py Outdated Show resolved Hide resolved
tests/suite/test_virtual_server_dos.py Outdated Show resolved Hide resolved
@lucacome lucacome added this to the v2.4.0 milestone Jul 11, 2022
@pasmant pasmant force-pushed the fqdn_arb branch 2 times, most recently from efa8ef8 to c09a0bc Compare August 21, 2022 07:29
@lucacome lucacome requested a review from a team August 22, 2022 20:47
@lucacome lucacome requested a review from a team August 23, 2022 01:14
@lucacome lucacome self-assigned this Aug 23, 2022
@lucacome lucacome force-pushed the fqdn_arb branch 2 times, most recently from da58227 to 730bfbc Compare August 23, 2022 18:54
@lucacome lucacome merged commit b751692 into nginxinc:main Aug 24, 2022
@ciarams87 ciarams87 added the enhancement Pull requests for new features/feature enhancements label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants