Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to only include separators when necessary (#2766) #2767

Merged
merged 4 commits into from Jul 15, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jun 17, 2022

Proposed changes

Only include or ; when there is going to be content on the other side...

#2766

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome lucacome linked an issue Jun 30, 2022 that may be closed by this pull request
@lucacome lucacome requested review from a team, ciarams87, jjngx and shaun-nx July 11, 2022 22:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #2767 (257de73) into main (1070031) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 257de73 differs from pull request most recent head 06128f3. Consider uploading reports for the commit 06128f3 to get more accurate results

@@            Coverage Diff             @@
##             main    #2767      +/-   ##
==========================================
- Coverage   53.08%   53.02%   -0.06%     
==========================================
  Files          58       58              
  Lines       15625    15641      +16     
==========================================
  Hits         8294     8294              
- Misses       7052     7068      +16     
  Partials      279      279              
Impacted Files Coverage Δ
internal/k8s/controller.go 11.71% <0.00%> (-0.08%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome modified the milestones: v2.3.0, v2.4.0 Jul 12, 2022
@ciarams87 ciarams87 enabled auto-merge (squash) July 15, 2022 09:09
@ciarams87 ciarams87 merged commit 0e7e34d into nginxinc:main Jul 15, 2022
@ciarams87 ciarams87 added the chore Pull requests for routine tasks label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing whitespace in VirtualServer status message
4 participants