Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGINX Ingress with Istio Service Mesh document #2768

Merged
merged 25 commits into from Aug 4, 2022
Merged

NGINX Ingress with Istio Service Mesh document #2768

merged 25 commits into from Aug 4, 2022

Conversation

jasonwilliams14
Copy link
Contributor

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jasonwilliams14 jasonwilliams14 added the documentation Pull requests/issues for documentation label Jun 17, 2022
Changes look good and added changes.

Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Copy link
Contributor Author

@jasonwilliams14 jasonwilliams14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all suggestions look good. Added them.

docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Show resolved Hide resolved
jasonwilliams14 and others added 12 commits July 21, 2022 08:17
Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
Removed unnecessary section on removing Istio.
Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-ingress-istio.md Show resolved Hide resolved
@travisamartin travisamartin marked this pull request as ready for review August 2, 2022 16:49
@lucacome lucacome changed the base branch from staging to main August 4, 2022 16:52
@lucacome lucacome merged commit 1288dbc into main Aug 4, 2022
@lucacome lucacome deleted the tutorials-2.2 branch August 4, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants