Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.3.0 #2821

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Release 2.3.0 #2821

merged 1 commit into from
Jul 11, 2022

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Jul 4, 2022 •
edited

Proposed changes

Release 2.3.0.

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022 •
edited

Codecov Report

Merging #2821 (d9e4b3a) into release-2.3 (439abda) will increase coverage by 0.68%.
The diff coverage is n/a.

❗ Current head d9e4b3a differs from pull request most recent head eee1cda. Consider uploading reports for the commit eee1cda to get more accurate results

@@               Coverage Diff               @@
##           release-2.3    #2821      +/-   ##
===============================================
+ Coverage        53.10%   53.79%   +0.68%     
===============================================
  Files               58       55       -3     
  Lines            15625    15273     -352     
===============================================
- Hits              8298     8216      -82     
+ Misses            7050     6779     -271     
- Partials           277      278       +1
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
internal/externaldns/controller.go
internal/externaldns/handlers.go
internal/externaldns/sync.go
internal/k8s/controller.go 11.81% <0.00%> (+0.02%) ⬆️
pkg/apis/configuration/validation/virtualserver.go 94.74% <0.00%> (+0.38%) ⬆️
cmd/nginx-ingress/flags.go 27.09% <0.00%> (+0.51%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ciarams87 ciarams87 marked this pull request as ready for review July 5, 2022 14:29
jjngx
jjngx approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ciarams87 ciarams87 merged commit 0606db2 into release-2.3 Jul 11, 2022
@ciarams87 ciarams87 deleted the r-2.3.0 branch July 11, 2022 14:22
lucacome pushed a commit that referenced this pull request Jul 11, 2022
@ciarams87 @lucacome
Release 2.3.0 (#2821)
6cb3db1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdomanski kdomanski kdomanski approved these changes

@brianehlert brianehlert brianehlert approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

@lucacome lucacome Awaiting requested review from lucacome lucacome was automatically assigned from nginxinc/kic

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ciarams87 @codecov-commenter @kdomanski @brianehlert @jjngx @shaun-nx