Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nginxcontrib/nginx as base image for UBI #2845

Merged
merged 2 commits into from Nov 2, 2022
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jul 13, 2022

nginxcontrib/nginx-ubi:1.23.1 mimics nginx:1.23.1 and nginx:1.23.1-alpine but for UBI.

  • Removes the need to manually add the nginx user
  • Removes the need to manually add the nginx repo
  • Adds builds for linux/ppc64le
  • The image adds nginx-module-xslt, nginx-module-image-filter and nginx-module-njs like for debian and alpine

@lucacome lucacome added the proposal An issue that proposes a feature request label Jul 13, 2022
@lucacome lucacome requested a review from a team July 13, 2022 02:14
@lucacome lucacome self-assigned this Jul 13, 2022
@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation labels Jul 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #2845 (af95533) into main (af95533) will not change coverage.
The diff coverage is n/a.

❗ Current head af95533 differs from pull request most recent head 236db07. Consider uploading reports for the commit 236db07 to get more accurate results

@@           Coverage Diff           @@
##             main    #2845   +/-   ##
=======================================
  Coverage   52.56%   52.56%           
=======================================
  Files          58       58           
  Lines       16069    16069           
=======================================
  Hits         8446     8446           
  Misses       7347     7347           
  Partials      276      276           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hafe
Copy link
Contributor

hafe commented Oct 1, 2022

This is not a good idea since users would not be able to (re)build the final image when RH has released a new version of the base image (e.g. with CVE fixes).

@lucacome
Copy link
Member Author

lucacome commented Oct 1, 2022

This is not a good idea since users would not be able to (re)build the final image when RH has released a new version of the base image (e.g. with CVE fixes).

@hafe why wouldn’t users be able to rebuild the final image?

@hafe
Copy link
Contributor

hafe commented Oct 2, 2022

This is not a good idea since users would not be able to (re)build the final image when RH has released a new version of the base image (e.g. with CVE fixes).

@hafe why wouldn’t users be able to rebuild the final image?

Sorry I misread the diff! Now I see redhat/ubi8 is still the base image!

@lucacome lucacome changed the title Use nginxcontrib/nginx-ubi as base image for UBI Use nginxcontrib/nginx as base image for UBI Nov 2, 2022
@lucacome lucacome merged commit 63716cd into main Nov 2, 2022
@lucacome lucacome deleted the deps/use-nginx-ubi branch November 2, 2022 23:38
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation proposal An issue that proposes a feature request
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

6 participants