Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change alpine version grab to include a colon in the updater #2848

Merged
merged 2 commits into from Jul 13, 2022

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Jul 13, 2022

Proposed changes

See https://github.com/nginxinc/kubernetes-ingress/runs/7316328564?check_suite_focus=true

The grep pulls the version from the opentracing image instead of the alpine image at the moment (resulting in an image tag of nginx-1.23.0-alpine instead of 1.23.0-alpine) causing failures.

The fix is to put a colon in so that get the right image tag.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested review from lucacome, a team, jjngx and shaun-nx July 13, 2022 14:43
@github-actions github-actions bot added the bug An issue reporting a potential bug label Jul 13, 2022
@lucacome lucacome merged commit 515e983 into main Jul 13, 2022
@lucacome lucacome deleted the fix-updater branch July 13, 2022 22:18
@lucacome lucacome added chore Pull requests for routine tasks and removed bug An issue reporting a potential bug labels Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants