Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace glog with forked version to include years #2876

Merged
merged 3 commits into from Jul 25, 2022

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Jul 21, 2022

Proposed changes

Replace glog with the nginx forked version to allow year to be included in logs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added dependencies Pull requests that update a dependency file enhancement Pull requests for new features/feature enhancements labels Jul 21, 2022
@haywoodsh haywoodsh force-pushed the feature/replace-glog-with-forked-version branch from 40bd214 to beb9e42 Compare July 21, 2022 16:23
@haywoodsh haywoodsh marked this pull request as ready for review July 22, 2022 09:35
@codecov-commenter
Copy link

Codecov Report

Merging #2876 (8368fb7) into main (2e71d2a) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2876      +/-   ##
==========================================
- Coverage   53.05%   53.02%   -0.03%     
==========================================
  Files          58       58              
  Lines       15641    15641              
==========================================
- Hits         8298     8294       -4     
- Misses       7066     7068       +2     
- Partials      277      279       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@haywoodsh haywoodsh merged commit 37b0866 into main Jul 25, 2022
@haywoodsh haywoodsh deleted the feature/replace-glog-with-forked-version branch July 25, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants