Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segregate IC and custom resources fixtures #2908

Merged
merged 2 commits into from Aug 5, 2022
Merged

segregate IC and custom resources fixtures #2908

merged 2 commits into from Aug 5, 2022

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Aug 4, 2022 •
edited

Proposed changes

  • Create separate fixture files for IC and custom-resources
  • Fix imports related to above changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added bug An issue reporting a potential bug tests Pull requests that update tests labels Aug 4, 2022
@vepatel vepatel merged commit 6fe9fde into main Aug 5, 2022
@vepatel vepatel deleted the tests/refactor-fixtures branch August 5, 2022 14:58
@lucacome lucacome removed the bug An issue reporting a potential bug label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vepatel @haywoodsh @shaun-nx @lucacome