Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod perf checks for multiple namespaces #2934

Merged
merged 8 commits into from Aug 25, 2022
Merged

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Aug 17, 2022

Proposed changes

Adds pod performance metrics for when multiple-namespace feature is active
Sample Output:
Screenshot 2022-08-17 at 16 17 42

pytest command:
pytest -v -s -m multi_ns --ns-count=<anything>0> --replicas=<anything>0>

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the tests Pull requests that update tests label Aug 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #2934 (5abb731) into main (fafa6ba) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2934      +/-   ##
==========================================
- Coverage   52.30%   52.28%   -0.02%     
==========================================
  Files          58       58              
  Lines       15965    15965              
==========================================
- Hits         8350     8348       -2     
- Misses       7335     7337       +2     
  Partials      280      280              
Impacted Files Coverage Δ
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel enabled auto-merge (squash) August 24, 2022 16:42
@vepatel vepatel disabled auto-merge August 24, 2022 16:43
@vepatel vepatel merged commit 57b9923 into main Aug 25, 2022
@vepatel vepatel deleted the tests/multiple-ns-metrics branch August 25, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants