Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "new" & redundant text, add "recommended" #2938

Merged
merged 2 commits into from Aug 17, 2022
Merged

Remove "new" & redundant text, add "recommended" #2938

merged 2 commits into from Aug 17, 2022

Conversation

jnewfield
Copy link
Contributor

Proposed changes

Remove the word "new" in the description text these resources have been implemented for a while now
Add the word "recommended" in the description text as F5 recommends and prefers the VirtualServer and VirtualServerRoute resources be implemented over the Ingress resource
Remove redundant text as there is no need to convey 'alternative to Ingress' twice

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • [NA] I have added tests that prove my fix is effective or that my feature works
  • [NA] I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • [?] I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Remove the word "new" and add the word "recommended" in the description text 
  - These resources have been implemented for a while now
  - F5 recommends and prefers the VirtualServer and VirtualServerRoutes resources be implemented over the Ingress resource
Remove redundant text (no need to convey 'alternative to Ingress' twice)
@jnewfield jnewfield marked this pull request as draft August 17, 2022 19:06
@jnewfield jnewfield marked this pull request as ready for review August 17, 2022 19:06
@lucacome lucacome requested a review from a team August 17, 2022 19:13
…e-resources.md

Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com>
@lucacome lucacome merged commit e1d867e into nginxinc:main Aug 17, 2022
@jnewfield jnewfield deleted the DOCOPS-1360-cp-main branch August 29, 2022 21:46
@lucacome lucacome added the documentation Pull requests/issues for documentation label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants