Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix links in the NAP config doc #2982

Merged
merged 1 commit into from Aug 30, 2022
Merged

docs: Fix links in the NAP config doc #2982

merged 1 commit into from Aug 30, 2022

Conversation

ciarams87
Copy link
Member

Proposed changes

Fix GitHub examples links and the NAP external references links in the NAP config doc

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested review from a team, lucacome, haywoodsh and jjngx August 30, 2022 08:28
@github-actions github-actions bot added bug An issue reporting a potential bug documentation Pull requests/issues for documentation labels Aug 30, 2022
@ciarams87 ciarams87 merged commit d8105f6 into release-2.3 Aug 30, 2022
@ciarams87 ciarams87 deleted the docs-fix branch August 30, 2022 10:37
@lucacome lucacome removed the bug An issue reporting a potential bug label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

@lucacome lucacome Awaiting requested review from lucacome lucacome was automatically assigned from nginxinc/kic

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

@jjngx jjngx Awaiting requested review from jjngx jjngx was automatically assigned from nginxinc/kic

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ciarams87 @vepatel @shaun-nx @lucacome