Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove repeat test and add wait_and_assert #2984

Merged
merged 6 commits into from Sep 5, 2022
Merged

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Aug 30, 2022

Proposed changes

  • add wait_and_assert for status_code checks
  • remove redundant tests (scenarios covered by newer tests)
  • add pytest arg to echo slowest 10 tests at the end of job

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the tests Pull requests that update tests label Aug 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #2984 (99c72ce) into main (7c95cd1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2984   +/-   ##
=======================================
  Coverage   52.26%   52.26%           
=======================================
  Files          58       58           
  Lines       15989    15989           
=======================================
  Hits         8357     8357           
  Misses       7354     7354           
  Partials      278      278           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel marked this pull request as ready for review September 5, 2022 14:13
@vepatel vepatel merged commit 03bc1d4 into main Sep 5, 2022
@vepatel vepatel deleted the tests/add-retry-assert-ap branch September 5, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants