Add lifecycle for controller container to helm chart #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
requested changes
Sep 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #3005 +/- ##
==========================================
- Coverage 52.31% 52.29% -0.03%
==========================================
Files 58 58
Lines 15995 15995
==========================================
- Hits 8368 8364 -4
- Misses 7350 7352 +2
- Partials 277 279 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
coolbry95
force-pushed
the
addlifecyclclehooks
branch
from
2ea3ffa
to
672b7e0
Compare
coolbry95
force-pushed
the
addlifecyclclehooks
branch
from
a3c2b99
to
5cf017b
Compare
coolbry95
force-pushed
the
addlifecyclclehooks
branch
from
5cf017b
to
bf20e86
Compare
vepatel
approved these changes
Sep 12, 2022
jjngx
approved these changes
Sep 12, 2022
|
Is there anything left to do here or can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding lifecycle to controller container. #3006
Checklist
Before creating a PR, run through this checklist and mark each as complete.