Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in anchor link #3013

Merged
merged 1 commit into from Sep 6, 2022
Merged

Fix typo in anchor link #3013

merged 1 commit into from Sep 6, 2022

Conversation

tomasohaodha
Copy link
Contributor

Proposed changes

This is a docs fix for bug KIC-995, correcting a typo in an anchor link.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@tomasohaodha tomasohaodha self-assigned this Sep 5, 2022
@github-actions github-actions bot added bug An issue reporting a potential bug documentation Pull requests/issues for documentation labels Sep 5, 2022
Jcahilltorre
Jcahilltorre reviewed Sep 5, 2022
View reviewed changes
Copy link
Contributor

@Jcahilltorre Jcahilltorre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
preview looks good. Link works.
https://deploy-preview-3013--nginx-kubernetes-ingress.netlify.app/nginx-ingress-controller/configuration/virtualserver-and-virtualserverroute-resources/#virtualserverroute

@lucacome lucacome removed the bug An issue reporting a potential bug label Sep 6, 2022
@lucacome lucacome changed the title Fix for bug KIC-995 (typo in anchor link) Fix typo in anchor link Sep 6, 2022
@lucacome lucacome merged commit c9bedae into main Sep 6, 2022
@lucacome lucacome deleted the bug/docs-KIC-995 branch September 6, 2022 17:02
ciarams87 pushed a commit that referenced this pull request Sep 7, 2022
@tomasohaodha @ciarams87
Fix typo in anchor link (#3013)
3204a40
@ciarams87 ciarams87 mentioned this pull request Sep 7, 2022
Merged
6 tasks
lucacome pushed a commit that referenced this pull request Sep 9, 2022
@ciarams87 @tomasohaodha
docs: Fix typo in anchor link (#3013) (#3020)
7274fe4 
Fix typo in anchor link (#3013)

Co-authored-by: tomasohaodha <86358393+tomasohaodha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jcahilltorre Jcahilltorre Jcahilltorre left review comments

@haywoodsh haywoodsh haywoodsh approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx Awaiting requested review from jjngx

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

Assignees

@tomasohaodha tomasohaodha

Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tomasohaodha @haywoodsh @vepatel @Jcahilltorre @lucacome