Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helloworld.proto and re-generate files #3091

Merged
merged 4 commits into from Sep 23, 2022
Merged

Add helloworld.proto and re-generate files #3091

merged 4 commits into from Sep 23, 2022

Conversation

lucacome
Copy link
Member

Adds helloworld.proto and regenerates files.

@lucacome lucacome requested review from vepatel and a team September 22, 2022 18:00
@lucacome lucacome self-assigned this Sep 22, 2022
@github-actions github-actions bot added documentation Pull requests/issues for documentation tests Pull requests that update tests labels Sep 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #3091 (4e9a3a7) into main (23be85f) will decrease coverage by 0.02%.
The diff coverage is 45.45%.

❗ Current head 4e9a3a7 differs from pull request most recent head f214528. Consider uploading reports for the commit f214528 to get more accurate results

@@            Coverage Diff             @@
##             main    #3091      +/-   ##
==========================================
- Coverage   52.31%   52.28%   -0.03%     
==========================================
  Files          58       58              
  Lines       15995    16006      +11     
==========================================
+ Hits         8368     8369       +1     
- Misses       7350     7358       +8     
- Partials      277      279       +2     
Impacted Files Coverage Δ
cmd/nginx-ingress/flags.go 34.42% <ø> (ø)
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
internal/configs/config_params.go 76.74% <ø> (ø)
internal/configs/version1/config.go 0.00% <ø> (ø)
internal/configs/version2/http.go 0.00% <ø> (ø)
internal/k8s/controller.go 11.10% <0.00%> (-0.02%) ⬇️
internal/configs/configmaps.go 20.37% <100.00%> (+0.16%) ⬆️
internal/configs/transportserver.go 93.81% <100.00%> (+0.03%) ⬆️
internal/configs/virtualserver.go 95.22% <100.00%> (+<0.01%) ⬆️
internal/k8s/configuration.go 95.39% <100.00%> (-0.37%) ⬇️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome merged commit 8c4d8e9 into main Sep 23, 2022
@lucacome lucacome deleted the tests/grpc branch September 23, 2022 16:42
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants