Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Revert change to gitlab branch ref #3093

Merged
merged 1 commit into from Sep 23, 2022
Merged

chore: Revert change to gitlab branch ref #3093

merged 1 commit into from Sep 23, 2022

Conversation

ciarams87
Copy link
Member

Proposed changes

The gitlab pipelines branch was accidentally set to the last release branch in main. This commit reverts that change

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 merged commit 1f48588 into main Sep 23, 2022
@ciarams87 ciarams87 deleted the fix-gitlab-tag branch September 23, 2022 15:02
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Sep 23, 2022
@ciarams87 @coolbry95
chore: Revert change to gitlab branch ref (nginxinc#3093)
873c465 
Revert change to gitlab branch ref
@ciarams87 ciarams87 added the tests Pull requests that update tests label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx Awaiting requested review from jjngx jjngx is a code owner automatically assigned from nginxinc/kic

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx is a code owner automatically assigned from nginxinc/kic

@lucacome lucacome Awaiting requested review from lucacome

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ciarams87 @haywoodsh @vepatel