Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise path validation #3094

Merged
merged 3 commits into from Sep 28, 2022
Merged

Optimise path validation #3094

merged 3 commits into from Sep 28, 2022

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Sep 23, 2022 •
edited

Proposed changes

Optimize path validation and add test cases.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the bug An issue reporting a potential bug label Sep 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022 •
edited

Codecov Report

Merging #3094 (f661486) into main (c9ea1e5) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3094      +/-   ##
==========================================
+ Coverage   52.41%   52.52%   +0.10%     
==========================================
  Files          58       58              
  Lines       15997    16033      +36     
==========================================
+ Hits         8385     8421      +36     
  Misses       7336     7336              
  Partials      276      276
Impacted Files Coverage Δ
internal/k8s/validation.go 93.81% <100.00%> (+0.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ciarams87 ciarams87 added chore Pull requests for routine tasks and removed bug An issue reporting a potential bug labels Sep 27, 2022
@haywoodsh haywoodsh force-pushed the fix/ingress-regex-path-validation branch from 9c1205d to ff9df8c Compare September 27, 2022 16:53
@github-actions github-actions bot added bug An issue reporting a potential bug and removed chore Pull requests for routine tasks labels Sep 27, 2022
@haywoodsh haywoodsh force-pushed the fix/ingress-regex-path-validation branch 2 times, most recently from 464a2f9 to bda9f45 Compare September 27, 2022 17:00
@haywoodsh haywoodsh added chore Pull requests for routine tasks and removed bug An issue reporting a potential bug labels Sep 27, 2022
@haywoodsh haywoodsh force-pushed the fix/ingress-regex-path-validation branch from de28c8e to f661486 Compare September 28, 2022 09:31
@github-actions github-actions bot added bug An issue reporting a potential bug and removed chore Pull requests for routine tasks labels Sep 28, 2022
@haywoodsh haywoodsh marked this pull request as ready for review September 28, 2022 10:01
shaun-nx
shaun-nx approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

jjngx
jjngx approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 👍🏻

ciarams87
ciarams87 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@haywoodsh haywoodsh merged commit d24bd22 into main Sep 28, 2022
@haywoodsh haywoodsh deleted the fix/ingress-regex-path-validation branch September 28, 2022 13:41
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
@haywoodsh @coolbry95
Optimise path validation (nginxinc#3094)
3406737 
* update path validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

@pleshakov pleshakov Awaiting requested review from pleshakov

@lucacome lucacome Awaiting requested review from lucacome

Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@haywoodsh @codecov-commenter @ciarams87 @vepatel @jjngx @shaun-nx