Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change AppProtect warning message #3096

Merged
merged 3 commits into from Sep 26, 2022
Merged

Change AppProtect warning message #3096

merged 3 commits into from Sep 26, 2022

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Sep 26, 2022 •
edited

Proposed changes

  • Change AppProtect warning message.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the tests Pull requests that update tests label Sep 26, 2022
shaun-nx
shaun-nx approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ciarams87
ciarams87 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vepatel vepatel merged commit 720ee28 into main Sep 26, 2022
@vepatel vepatel deleted the tests/fix-appprotect-message branch September 26, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

@lucacome lucacome Awaiting requested review from lucacome

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vepatel @ciarams87 @shaun-nx