Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make target for running staticcheck locally #3110

Merged
merged 7 commits into from Oct 13, 2022

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Sep 29, 2022

Proposed changes

This PR adds a make target staticcheck that runs staticcheck linter locally.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested review from lucacome, a team, haywoodsh and shaun-nx September 29, 2022 12:09
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 29, 2022
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangci-lint is already running staticcheck, what is the difference with this?

@jjngx
Copy link
Contributor Author

jjngx commented Sep 29, 2022

golangci-lint is already running staticcheck, what is the difference with this?

staticcheck in golangci-lint is a subset of checks implemented by staticcheck project (binary). more info here

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #3110 (8b048ed) into main (af95533) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3110      +/-   ##
==========================================
- Coverage   52.56%   52.54%   -0.02%     
==========================================
  Files          58       58              
  Lines       16069    16069              
==========================================
- Hits         8446     8444       -2     
- Misses       7347     7349       +2     
  Partials      276      276              
Impacted Files Coverage Δ
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx merged commit d04b324 into main Oct 13, 2022
@jjngx jjngx deleted the chore/staticcheck-make-target branch October 13, 2022 18:33
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants