Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add canary header and update ap waf log pod #3116

Merged
merged 6 commits into from Sep 30, 2022
Merged

add canary header and update ap waf log pod #3116

merged 6 commits into from Sep 30, 2022

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Sep 30, 2022 •
edited

Proposed changes

  • Add canary header in ensure_responses
  • Use lib function to get pod name

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the tests Pull requests that update tests label Sep 30, 2022
jjngx
jjngx approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

ciarams87
ciarams87 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@vepatel vepatel merged commit b73f771 into main Sep 30, 2022
@vepatel vepatel deleted the tests/fix-flakiness branch September 30, 2022 13:53
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
@vepatel @coolbry95
add canary header and update syslog yaml for AP tests (nginxinc#3116)
59ed736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@tomasohaodha tomasohaodha tomasohaodha approved these changes

@jjngx jjngx jjngx approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vepatel @ciarams87 @tomasohaodha @jjngx