Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update helm rbac template for watch-ns #3122

Merged
merged 1 commit into from Oct 3, 2022
Merged

Update helm rbac template for watch-ns #3122

merged 1 commit into from Oct 3, 2022

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Oct 3, 2022 •
edited

Proposed changes

  • Update helm rbac template for watching namespaces

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the bug An issue reporting a potential bug label Oct 3, 2022
@vepatel vepatel merged commit c47d5bf into main Oct 3, 2022
@vepatel vepatel deleted the fix/helm-watch-namespace branch October 3, 2022 14:44
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
@vepatel @coolbry95
Update helm rbac template for watch-ns (nginxinc#3122)
ab8ac9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vepatel @haywoodsh @ciarams87 @jjngx @shaun-nx