Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order and adjust custom resource headings for installation via manifest #3141

Merged
merged 2 commits into from Oct 12, 2022

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Oct 12, 2022

This commit implements many of the suggestions made in KIC-997: it clarifies the hierarchy and steps involved with the installation process. There are also some minor formatting changes included.

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit implements many of the suggestions made in KIC-997:
it clarifies the hierarchy and steps involved with the installation
process. There are also some minor formatting changes included.
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 12, 2022
@ADubhlaoich ADubhlaoich enabled auto-merge (squash) October 12, 2022 14:01
@tomasohaodha tomasohaodha merged commit b35caf6 into main Oct 12, 2022
@tomasohaodha tomasohaodha deleted the kic-997 branch October 12, 2022 16:04
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
…ifest (nginxinc#3141)

feat: Re-order and adjust custom resource headings

This commit implements many of the suggestions made in KIC-997:
it clarifies the hierarchy and steps involved with the installation
process. There are also some minor formatting changes included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants