Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Action.Proxy.ResponseHeaders #3157

Merged
merged 2 commits into from Oct 18, 2022
Merged

Conversation

tomasohaodha
Copy link
Contributor

Corrected bool to []string in Action.Proxy.ResponseHeaders section

Proposed changes

Simple typo fix in the Action.Proxy.ResponseHeaders section.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Corrected bool to []string in Action.Proxy.ResponseHeaders section
@tomasohaodha tomasohaodha added the documentation Pull requests/issues for documentation label Oct 17, 2022
@tomasohaodha tomasohaodha merged commit 4824823 into main Oct 18, 2022
@tomasohaodha tomasohaodha deleted the docs/ResponseHeaders-typo branch October 18, 2022 15:57
haywoodsh pushed a commit that referenced this pull request Oct 19, 2022
Corrected bool to []string in Action.Proxy.ResponseHeaders section

(cherry picked from commit 4824823)
@haywoodsh haywoodsh mentioned this pull request Oct 19, 2022
6 tasks
ciarams87 added a commit that referenced this pull request Oct 19, 2022
* Remove all IPV6 listeners in ingress resources with -disable-ipv6 command line  (#3139)

* Remove ipv6 listeners in ingress upstream with command line argument

Co-authored-by: Venktesh <ve.patel@f5.com>
(cherry picked from commit 4e6caf0)

* Fix typo in Action.Proxy.ResponseHeaders (#3157)

Corrected bool to []string in Action.Proxy.ResponseHeaders section

(cherry picked from commit 4824823)

Co-authored-by: Ciara Stacke <18287516+ciarams87@users.noreply.github.com>
Co-authored-by: tomasohaodha <86358393+tomasohaodha@users.noreply.github.com>
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Corrected bool to []string in Action.Proxy.ResponseHeaders section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants