Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for 2.4.1 (#3184) #3194

Merged
merged 3 commits into from Nov 3, 2022
Merged

Docs for 2.4.1 (#3184) #3194

merged 3 commits into from Nov 3, 2022

Conversation

ciarams87
Copy link
Member

Co-authored-by: Luca Comellini luca.com@gmail.com

Proposed changes

Merge docs changes from v2.4.1

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Co-authored-by: Luca Comellini <luca.com@gmail.com>
@ciarams87 ciarams87 requested a review from a team as a code owner October 21, 2022 14:29
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Merging #3194 (8510d68) into main (a9f9f8d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3194   +/-   ##
=======================================
  Coverage   52.55%   52.55%           
=======================================
  Files          58       58           
  Lines       16070    16070           
=======================================
  Hits         8445     8445           
  Misses       7349     7349           
  Partials      276      276           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ciarams87 ciarams87 changed the title Release 2.4.1 (#3184) Docs for 2.4.1 (#3184) Oct 21, 2022
@lucacome
Copy link
Member

I think there are more docs changes that are not in the PR, we should just merge the branch imo

@ciarams87
Copy link
Member Author

@lucacome there were merge conflicts that couldn't be resolved. There shouldn't be any other docs changes that didn't make it into main first, but I will do a sweep to check.

@ciarams87 ciarams87 merged commit d9fe6a2 into main Nov 3, 2022
@ciarams87 ciarams87 deleted the merge-2.4.1-main branch November 3, 2022 13:09
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
* Release 2.4.1 (nginxinc#3184)

Co-authored-by: Luca Comellini <luca.com@gmail.com>

* Update docs/content/technical-specifications.md

Co-authored-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants