Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helloworld grpc generated file #3220

Merged
merged 2 commits into from Nov 7, 2022
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Nov 3, 2022

Updates python code generated by the protocol buffer compiler for helloworld.proto, using the latest version of protobuf.

This is achieved by running

python3 -m grpc_tools.protoc --proto_path=. --python_out=. --grpc_python_out=. helloworld.proto

as described in the README.

@lucacome lucacome self-assigned this Nov 3, 2022
@lucacome lucacome requested a review from a team as a code owner November 3, 2022 19:36
@github-actions github-actions bot added tests Pull requests that update tests documentation Pull requests/issues for documentation labels Nov 3, 2022
@github-actions github-actions bot removed the documentation Pull requests/issues for documentation label Nov 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #3220 (6df6235) into main (fb6bbeb) will not change coverage.
The diff coverage is n/a.

❗ Current head 6df6235 differs from pull request most recent head f8fe777. Consider uploading reports for the commit f8fe777 to get more accurate results

@@           Coverage Diff           @@
##             main    #3220   +/-   ##
=======================================
  Coverage   52.52%   52.52%           
=======================================
  Files          58       58           
  Lines       16070    16070           
=======================================
  Hits         8441     8441           
  Misses       7351     7351           
  Partials      278      278           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tomasohaodha tomasohaodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add more detail to the PR. "Regenerated hello world pb2" is not helpful to devs who do not already have context. Thanks.

@lucacome
Copy link
Member Author

lucacome commented Nov 5, 2022

@tomasohaodha updated the description

@tomasohaodha
Copy link
Contributor

@tomasohaodha updated the description

@lucacome Thanks!

@lucacome lucacome merged commit 2b5855c into main Nov 7, 2022
@lucacome lucacome deleted the tests/update-generateed branch November 7, 2022 17:29
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants