New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pre-commit hooks to fix python test imports #3221
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3221 +/- ##
==========================================
+ Coverage 52.52% 52.56% +0.03%
==========================================
Files 58 59 +1
Lines 16070 16080 +10
==========================================
+ Hits 8441 8452 +11
Misses 7351 7351
+ Partials 278 277 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3f1ad19
to
2dd6440
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impossible to review a PR with 511 files changed with just 'Fixes all the formatting in the codebase' as the description. I would suggest either package it to have fewer files per review, or explain in-depth what is being changed so that anomalies can be easily detected (although even then, 511 files is a lot).
Hi @lucacome, should there also be corresponding checks in the CI pipeline for the hooks you added? From what I understand about pre-commit hooks, users can skip them if they choose to. If the same tests don't exist in the CI pipeline, could it be possible that a pull request is merged without passing those commit hooks, and the next developer who pull from the main branch will have have to fix the code themselves? |
@haywoodsh yes there's going to be a check. I've enabled it briefly but it was trying to fix all the files at once instead of fixing only the modified files. I haven't found a way yet to customize the app, so I've disabled it for now. |
@tomasohaodha I've opened #3223 to move some of the docs changes there |
It's still showing all the whitespace-changed files. I assume you need to merge #3223 and then run the pre-commit again? |
@tomasohaodha yes just merged |
ae282dd
to
8e16668
Compare
8e16668
to
4774497
Compare
* Run pre-commit hooks to fix python test imports * Add context.minimum_version
fixtures
andutils
folders to move non-tests files from the main folder