Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Makefile var overrides (#3224) #3225

Merged
merged 1 commit into from Nov 7, 2022
Merged

Fix Makefile var overrides (#3224) #3225

merged 1 commit into from Nov 7, 2022

Conversation

hafe
Copy link
Contributor

@hafe hafe commented Nov 6, 2022

Proposed changes

FIx Makefile to allow variable overrides as documented.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [X ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@hafe hafe requested a review from a team as a code owner November 6, 2022 07:35
@ciarams87 ciarams87 merged commit 639524a into nginxinc:main Nov 7, 2022
@brianehlert brianehlert linked an issue Nov 7, 2022 that may be closed by this pull request
Makefile vars cannot be overridden as documented #3224
Closed
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
@hafe @coolbry95
Fix Makefile var overrides (nginxinc#3224) (nginxinc#3225)
568c707
@lucacome lucacome added the chore Pull requests for routine tasks label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

@lucacome lucacome Awaiting requested review from lucacome lucacome is a code owner automatically assigned from nginxinc/kic

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh is a code owner automatically assigned from nginxinc/kic

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Makefile vars cannot be overridden as documented
5 participants
@hafe @ciarams87 @vepatel @jjngx @lucacome