Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to http calls #3233

Merged
merged 2 commits into from Nov 11, 2022
Merged

Add context to http calls #3233

merged 2 commits into from Nov 11, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Nov 8, 2022

Adds context to http calls that check config version.
This fixes a couple of linter errors:

internal/nginx/verify.go:40:27: (*net/http.Client).Get must not be called (noctx)
internal/nginx/manager.go:436:29: should rewrite http.NewRequestWithContext or add (*Request).WithContext (noctx)

@lucacome lucacome self-assigned this Nov 8, 2022
@lucacome lucacome requested a review from a team as a code owner November 8, 2022 23:12
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3233 (94ad8eb) into main (91f9da8) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3233      +/-   ##
==========================================
- Coverage   52.58%   52.56%   -0.03%     
==========================================
  Files          59       59              
  Lines       16078    16088      +10     
==========================================
+ Hits         8454     8456       +2     
- Misses       7347     7354       +7     
- Partials      277      278       +1     
Impacted Files Coverage Δ
internal/nginx/manager.go 0.00% <0.00%> (ø)
internal/nginx/verify.go 56.94% <62.50%> (+0.02%) ⬆️
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome merged commit 6b41889 into main Nov 11, 2022
@lucacome lucacome deleted the chore/add-context-http branch November 11, 2022 00:38
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants