Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ineffective break #3235

Merged
merged 1 commit into from Nov 10, 2022
Merged

Remove ineffective break #3235

merged 1 commit into from Nov 10, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Nov 8, 2022

The break is not needed.
Fixes:

internal/k8s/spiffe.go:80:4: SA4011: ineffective break statement. Did you mean to break out of the outer loop? (staticcheck)

@lucacome lucacome self-assigned this Nov 8, 2022
@lucacome lucacome requested a review from a team as a code owner November 8, 2022 23:29
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 8, 2022
@lucacome
Copy link
Member Author

lucacome commented Nov 8, 2022

@kate-osborn I can't add you as a reviewer (🤷‍♂️) but I'm tagging you since it was your code

@lucacome lucacome merged commit 09e92c3 into main Nov 10, 2022
@lucacome lucacome deleted the chore/remove-ineffective-break branch November 10, 2022 17:00
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
@lucacome @coolbry95
Remove ineffective break (nginxinc#3235)
795aea1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@jjngx jjngx jjngx approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh is a code owner automatically assigned from nginxinc/kic

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucacome @ciarams87 @jjngx