Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary arg in generateTransportServerHealthCheckWithDefaults #3236

Merged
merged 1 commit into from Nov 9, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Nov 8, 2022

The argument is not used

@lucacome lucacome requested a review from a team as a code owner November 8, 2022 23:51
@lucacome lucacome self-assigned this Nov 8, 2022
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3236 (47da9c2) into main (6ab9416) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3236      +/-   ##
==========================================
+ Coverage   52.54%   52.56%   +0.01%     
==========================================
  Files          59       59              
  Lines       16080    16080              
==========================================
+ Hits         8450     8452       +2     
  Misses       7351     7351              
+ Partials      279      277       -2     
Impacted Files Coverage Δ
internal/configs/transportserver.go 97.48% <100.00%> (ø)
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️
internal/k8s/configuration.go 95.76% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome merged commit 530f5f5 into main Nov 9, 2022
@lucacome lucacome deleted the chore/remove-unnecessary-arg branch November 9, 2022 16:31
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants