Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script logic for validating tag #3237

Merged
merged 1 commit into from Nov 10, 2022
Merged

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Nov 10, 2022

Proposed changes

This change updated the /hack/docker.sh script to confirm that the tag used is within the list of tags in the commit_tag variable.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the bug An issue reporting a potential bug label Nov 10, 2022
@shaun-nx shaun-nx marked this pull request as ready for review November 10, 2022 13:39
@shaun-nx shaun-nx requested a review from a team as a code owner November 10, 2022 13:39
@codecov-commenter
Copy link

Codecov Report

Merging #3237 (d0f351b) into main (e0e4846) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
+ Coverage   52.48%   52.51%   +0.02%     
==========================================
  Files          59       59              
  Lines       16095    16095              
==========================================
+ Hits         8448     8452       +4     
+ Misses       7368     7366       -2     
+ Partials      279      277       -2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.76% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx merged commit 2a0b30c into main Nov 10, 2022
@shaun-nx shaun-nx deleted the fix/download-image-for-tag branch November 10, 2022 16:41
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Co-authored-by: “shaun-nx” <“s.odonovan@f5.com”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants