Fix git command to retrieve commit matching the tag #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To find the correct binary to use for the build when a user checks out a tag, we need to match the exact commit for the tag. `git tag --contains` would list all the tags containing the commit, but we need to verify that the commit we're on matches the current tag.
jasonwilliams14
approved these changes
Nov 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #3239 +/- ##
==========================================
- Coverage 52.50% 52.48% -0.03%
==========================================
Files 59 59
Lines 16104 16104
==========================================
- Hits 8456 8452 -4
- Misses 7370 7372 +2
- Partials 278 280 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tomasohaodha
approved these changes
Nov 11, 2022
coolbry95
pushed a commit
to coolbry95/kubernetes-ingress
that referenced
this pull request
Nov 18, 2022
To find the correct binary to use for the build when a user checks out a tag, we need to match the exact commit for the tag. `git tag --contains` would list all the tags containing the commit, but we need to verify that the commit we're on matches the current tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To find the correct binary to use for the build when a ueser checks out a tag, we need to match the exact commit for the tag.
git tag --containswould list all the tags containg the commit, but we need to verify that the commit we're on matches the current tag.