Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated tests for -watch-secret-namespace #3245

Merged
merged 9 commits into from Nov 15, 2022

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Nov 11, 2022

Proposed changes

  • Add 5 tests for diff. -watch-secret-namespace scenarios
  • Add helper function to check connection with specific SNI

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner November 11, 2022 17:27
@github-actions github-actions bot added the tests Pull requests that update tests label Nov 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #3245 (90d672d) into main (c676edb) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3245      +/-   ##
==========================================
- Coverage   52.67%   52.64%   -0.03%     
==========================================
  Files          59       59              
  Lines       16107    16107              
==========================================
- Hits         8484     8480       -4     
- Misses       7341     7343       +2     
- Partials      282      284       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel merged commit 01293a4 into main Nov 15, 2022
@vepatel vepatel deleted the tests/watch-secret-namespace branch November 15, 2022 14:33
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants