Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run golangci-lint in pre-commit only for changed files #3247

Merged
merged 2 commits into from Nov 14, 2022

Conversation

lucacome
Copy link
Member

This will also disables golangci-lint in pre-commit.ci (we'll still use the action) and removes lint-python as it's part of pre-commit

@lucacome lucacome requested a review from a team as a code owner November 12, 2022 03:31
@lucacome lucacome self-assigned this Nov 12, 2022
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Merging #3247 (657d4bc) into main (42dd0d1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3247      +/-   ##
==========================================
+ Coverage   52.48%   52.50%   +0.02%     
==========================================
  Files          59       59              
  Lines       16104    16104              
==========================================
+ Hits         8452     8456       +4     
+ Misses       7372     7370       -2     
+ Partials      280      278       -2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.76% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome merged commit c676edb into main Nov 14, 2022
@lucacome lucacome deleted the chore/add-rev-pre-commit branch November 14, 2022 17:20
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants