Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/flakiness tests ci kind #3266

Merged
merged 13 commits into from Nov 18, 2022
Merged

Tests/flakiness tests ci kind #3266

merged 13 commits into from Nov 18, 2022

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Nov 17, 2022

Proposed changes

  • Ensure connection before asserting 200s,
  • Add flaky markers for test retries.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner November 17, 2022 13:08
@github-actions github-actions bot added the tests Pull requests that update tests label Nov 17, 2022
@vepatel vepatel merged commit 2ee3f20 into main Nov 18, 2022
@vepatel vepatel deleted the tests/flakiness-tests-ci-kind branch November 18, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@jjngx jjngx jjngx approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vepatel @lucacome @jjngx