Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more 502 checks for test backends #3275

Merged
merged 1 commit into from Nov 18, 2022
Merged

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Nov 18, 2022

Proposed changes

  • Add more 502 checks in split-traffic tests
  • Fix test markers

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner November 18, 2022 15:52
@github-actions github-actions bot added the tests Pull requests that update tests label Nov 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3275 (30ed9d4) into main (2ee3f20) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3275   +/-   ##
=======================================
  Coverage   52.64%   52.64%           
=======================================
  Files          59       59           
  Lines       16107    16107           
=======================================
  Hits         8480     8480           
  Misses       7343     7343           
  Partials      284      284           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel merged commit 45d688f into main Nov 18, 2022
@vepatel vepatel deleted the tests/502-backend-checks branch November 18, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants